Fix switching windows with the 'Go' menu #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
commented
Nov 21, 2020
| @@ -200,7 +200,7 @@ def go_menu (self): | |||
| separator.show() | |||
| for rc in list(self.rc.values()): | |||
| i=Gtk.MenuItem("_%s"%rc.current_rec.title) | |||
| i.connect('activate',rc.show) | |||
There was a problem hiding this comment.
Looking further after I committed, I think this is dead code, and only the change below made a difference.
|
Nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start Gourmet, and open a recipe. Then try to switch between the open windows with the 'Go' menu. Switching to a recipe card fails with
TypeError: show() takes 1 positional argument but 2 were given. This PR fixes that, so you the menu entry works as expected.The issue is that the signal mechanism is passing an argument, but the
RecCard.show()method doesn't expect one. The solution, already used elsewhere in the code, is to wrap it in a lambda which discards the argument(s).How Has This Been Tested?
Followed the above steps manually.
Screenshots (if appropriate):
Types of changes
Checklist: